Re: [PATCH v2] pinctrl: sunxi: Implement gpiochip::get_direction()

[Linus Walleij]

On Tue, Feb 24, 2026 at 10:24 AM Chen-Yu Tsai <wens@xxxxxxxxxx> wrote:

> After commit 471e998c0e31 ("gpiolib: remove redundant callback check"),
> a warning will be printed if the gpio driver does not implement this
> callback. The warning was added in commit e623c4303ed1 ("gpiolib:
> sanitize the return value of gpio_chip::get_direction()"), but was
> masked by the "redundant" check.
>
> The warning can be triggered by any action that calls the callback,
> such as dumping the GPIO state from /sys/kernel/debug/gpio.
>
> Implement it for the sunxi driver. This is simply a matter of reading
> out the mux value from the registers, then checking if it is one of
> the GPIO functions and which direction it is.
>
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxxxx>
> Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>

Pulled out v1 of my tree and put in this one instead!

Yours,
Linus Walleij