Re: [PATCH v4 1/3] iio: frequency: ad9523: fix implicit variable usage in macros
From: Andy Shevchenko
Date: Tue Feb 24 2026 - 04:59:50 EST
On Tue, Feb 24, 2026 at 03:26:34AM +0530, Bhargav Joshi wrote:
> macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and
> AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable
> named 'ret' instead of using passed argument '(x)'.
>
> Update the macros to explicitly
> use the argument '(x)' for their operations.
>
> This also resolves the following checkpatch.pl warning:
> WARNING: Argument '(x)' is not used in function-like macro
Same problem as in v3 stays. Really, go to v3 review and address all comments,
or explain why not.
--
With Best Regards,
Andy Shevchenko