Re: [PATCH net-next v3] net: atlantic: fix reading SFP module info on some AQC100 cards

[Paolo Abeni]

On 2/23/26 1:41 AM, Tiernan Hubble wrote:
> @@ -992,15 +1024,15 @@ static int aq_ethtool_get_module_info(struct net_device *ndev,
>  
>  	/* Module EEPROM is only supported for controllers with external PHY */
>  	if (aq_nic->aq_nic_cfg.aq_hw_caps->media_type != AQ_HW_MEDIA_TYPE_FIBRE ||
> -	    !aq_nic->aq_hw_ops->hw_read_module_eeprom)
> +	    !aq_ethtool_can_read_module_eeprom(aq_nic))
>  		return -EOPNOTSUPP;
>  
> -	err = aq_nic->aq_hw_ops->hw_read_module_eeprom(aq_nic->aq_hw,
> +	err = aq_ethtool_read_module_eeprom(aq_nic,
>  		SFF_8472_ID_ADDR, SFF_8472_COMP_ADDR, 1, &compliance_val);

I'm sorry for nit picking, but here and later this leads a quite bad
indentation. You should reformat the whole argument list according to
the kernel coding style, i.e.
	
	err = aq_ethtool_read_module_eeprom(aq_nic, SFF_8472_ID_ADDR,
				            SFF_8472_COMP_ADDR, 1,
					    &compliance_val);

/P