Re: [PATCH 04/62] dax/bus.c: Fix a locking bug

[Jonathan Cameron]

On Mon, 23 Feb 2026 14:50:49 -0800
<dan.j.williams@xxxxxxxxx> wrote:

> Bart Van Assche wrote:
> > From: Bart Van Assche <bvanassche@xxxxxxx>
> > 
> > Only unlock dax_dev_rwsem if it has been locked. This locking bug was
> > detected by the Clang thread-safety analyzer.
> > 
> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> > Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> > Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
> > Cc: Alison Schofield <alison.schofield@xxxxxxxxx>
> > Cc: nvdimm@xxxxxxxxxxxxxxx
> > Cc: linux-cxl@xxxxxxxxxxxxxxx
> > Fixes: c05ae9d85b47 ("dax/bus.c: replace driver-core lock usage by a local rwsem")
> > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>  
> 
> Looks good,
> 
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> 

Agreed
Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>

Maybe worth some ACQUIRE() magic as a follow up.