Re: [PATCH v7 10/23] scsi: ufs: mediatek: Handle misc host voltage regulators

From: Mark Brown

Date: Tue Feb 24 2026 - 07:50:03 EST


On Tue, Feb 24, 2026 at 12:38:50PM +0000, Peter Wang (王信友) wrote:
> On Mon, 2026-02-16 at 14:37 +0100, Nicolas Frattaroli wrote:

> > + if (data->num_reg_names) {
> > + ret = devm_regulator_bulk_get_enable(dev, data-
> > >num_reg_names,
> > +      data-
> > >reg_names);

> If these regulators are only acquired and enabled once,
> why not just set regulator-always-on in the device tree?

Drivers should request and enable any regulators they require, they
should not rely on boards happening to enable a supply for them.
Similarly the board should only impose constraints that come from the
system design, it should not assume that drivers will continue to behave
as they do.

Attachment: signature.asc
Description: PGP signature