Re: [PATCH v5 5/6] clk: qcom: Add support for Global clock controller on Eliza

[Konrad Dybcio]

On 2/23/26 1:01 PM, Abel Vesa wrote:
> From: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> 
> Add support for Global clock controller for Eliza Qualcomm SoC.
> 
> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> ---

[...]

> +	[GCC_CAMERA_HF_AXI_SLP_STG_ARES] = { 0x26018, 4 },
> +	[GCC_CAMERA_SF_AXI_SLP_STG_ARES] = { 0x26028, 4 },
> +	[GCC_CAMERA_HF_AXI_SEL_SLP_STG_ARES] = { 0x26018, 5 },
> +	[GCC_CAMERA_SF_AXI_SEL_SLP_STG_ARES] = { 0x26028, 5 },

These are different from the ones we discussed at 

https://lore.kernel.org/all/d6392cb9-9ab2-4743-a13f-7432ec03762c@xxxxxxxxxxxxxxxx/

but they are also sort of similar in nature..

bit 5 selects hw (0) vs sw (1) control and bit 4 is the sw vote
for asserting (1) or de-asserting (0) the signal

Let's drop these too until we have a clear path forward

with these gone:

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad