RE: [PATCH v2] iio: adc: ade9000: fix wrong return type in streaming push

[Miclaus, Antoniu]

> -----Original Message-----
> From: Giorgi Tchankvetadze <giorgitchankvetadze1997@xxxxxxxxx>
> Sent: Tuesday, February 24, 2026 3:24 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@xxxxxxxxxx>
> Cc: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; lars@xxxxxxxxxx; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; jic23@xxxxxxxxxx; David Lechner
> <dlechner@xxxxxxxxxxxx>; andy@xxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Giorgi Tchankvetadze
> <giorgitchankvetadze1997@xxxxxxxxx>
> Subject: [PATCH v2] iio: adc: ade9000: fix wrong return type in streaming push
> 
> [External]
> 
> The else branch of ade9000_iio_push_streaming() incorrectly returns
> IRQ_HANDLED on regmap_write failure. This function returns int (0 on
> success, negative errno on failure), so IRQ_HANDLED (1) would be
> misinterpreted as a non-error by callers.
> 
> Return ret instead, consistent with every other error path in the
> function.
> 
> Fixes: 81de7b4619fc ("iio: adc: add ade9000 support")
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@xxxxxxxxx>
> ---

Reviewed-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>

> Changes in v2 (Antoniu Miclaus):
>  - Drop unrelated newline fix
>  - Add Fixes tag
> 
>  drivers/iio/adc/ade9000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ade9000.c b/drivers/iio/adc/ade9000.c
> index 5dcc26a08970..5d659f1bd3f7 100644
> --- a/drivers/iio/adc/ade9000.c
> +++ b/drivers/iio/adc/ade9000.c
> @@ -787,7 +787,7 @@ static int ade9000_iio_push_streaming(struct iio_dev
> *indio_dev)
>  				   ADE9000_MIDDLE_PAGE_BIT);
>  		if (ret) {
>  			dev_err_ratelimited(dev, "IRQ0 WFB write fail");
> -			return IRQ_HANDLED;
> +			return ret;
>  		}
> 
>  		ade9000_configure_scan(indio_dev,
> ADE9000_REG_WF_BUFF);
> --
> 2.52.0