Re: [PATCH v9] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride

[Konrad Dybcio]

On 2/23/26 6:51 AM, Wei Zhang (Stone) wrote:
> 
> On 2/5/2026 5:28 PM, Konrad Dybcio wrote:
>> On 1/22/26 6:36 AM, Wei Zhang wrote:
>>> Enable WLAN on qcs8300-ride by adding a node for the PMU module
>>> of the WCN6855 and assigning its LDO power outputs to the existing
>>> WiFi module.
>>>
>>> On the qcs8300-ride platform, the corresponding firmware and BDF
>>> are QCA6698AQ instead of WCN6855, which have been added in the
>>> 20250211 release.
>>>
>>> Signed-off-by: Wei Zhang <wei.zhang@xxxxxxxxxxxxxxxx>
>>> ---
>> [...]
>>
>>> +    wlan_en_state: wlan-en-state {
>>> +        pins = "gpio54";
>>> +        function = "gpio";
>>> +        bias-pull-up;
>>> +    };
>> pull-up sounds odd for an active-high pin
> Good point.
> GPIO54 is the active‑high WLAN_EN for WCN6855. The pull‑up is intentional to
> keep the line stable during early boot and to reduce the risk of a low‑to‑high glitch before the PMU driver takes control.
> WLAN enable/disable is still explicitly handled by the wcn6855‑pmu driver via wlan-enable-gpios.
> I can switch this if a different default is preferred.

Would such a glitch be problematic? This is an *enable* GPIO, not a reset
one

I would expect the WLAN is going to be off before Linux boots (unless that's
not the case here?)

Konrad