RE: [Intel-wired-lan] [PATCH iwl-next v5 04/15] libeth: allow to create fill queues without NAPI

From: Salin, Samuel

Date: Tue Feb 24 2026 - 12:18:32 EST


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of R,
> Bharath
> Sent: Monday, February 23, 2026 11:17 PM
> To: Zaremba, Larysa <larysa.zaremba@xxxxxxxxx>; intel-wired-
> lan@xxxxxxxxxxxxxxxx; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>
> Cc: Lobakin, Aleksander <aleksander.lobakin@xxxxxxxxx>; Samudrala, Sridhar
> <sridhar.samudrala@xxxxxxxxx>; Singhai, Anjali <anjali.singhai@xxxxxxxxx>;
> Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>; Zaremba, Larysa
> <larysa.zaremba@xxxxxxxxx>; Fijalkowski, Maciej
> <maciej.fijalkowski@xxxxxxxxx>; Tantilov, Emil S <emil.s.tantilov@xxxxxxxxx>;
> Chittim, Madhu <madhu.chittim@xxxxxxxxx>; Hay, Joshua A
> <joshua.a.hay@xxxxxxxxx>; Keller, Jacob E <jacob.e.keller@xxxxxxxxx>;
> Shanmugam, Jayaprakash <jayaprakash.shanmugam@xxxxxxxxx>;
> Wochtman, Natalia <natalia.wochtman@xxxxxxxxx>; Jiri Pirko
> <jiri@xxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>; Jonathan
> Corbet <corbet@xxxxxxx>; Richard Cochran <richardcochran@xxxxxxxxx>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 04/15] libeth: allow to create
> fill queues without NAPI
>
>
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf
> > Of Larysa Zaremba
> > Sent: 17 November 2025 19:19
> > To: intel-wired-lan@xxxxxxxxxxxxxxxx; Nguyen, Anthony L
> > <anthony.l.nguyen@xxxxxxxxx>
> > Cc: Lobakin, Aleksander <aleksander.lobakin@xxxxxxxxx>; Samudrala,
> > Sridhar <sridhar.samudrala@xxxxxxxxx>; Singhai, Anjali
> > <anjali.singhai@xxxxxxxxx>; Michal Swiatkowski
> > <michal.swiatkowski@xxxxxxxxxxxxxxx>; Zaremba, Larysa
> > <larysa.zaremba@xxxxxxxxx>; Fijalkowski, Maciej
> > <maciej.fijalkowski@xxxxxxxxx>; Tantilov, Emil S
> > <emil.s.tantilov@xxxxxxxxx>; Chittim, Madhu <madhu.chittim@xxxxxxxxx>;
> > Hay, Joshua A <joshua.a.hay@xxxxxxxxx>; Keller, Jacob E
> > <jacob.e.keller@xxxxxxxxx>; Shanmugam, Jayaprakash
> > <jayaprakash.shanmugam@xxxxxxxxx>;
> > Wochtman, Natalia <natalia.wochtman@xxxxxxxxx>; Jiri Pirko
> > <jiri@xxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> > Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo
> > Abeni <pabeni@xxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>;
> Jonathan
> > Corbet <corbet@xxxxxxx>; Richard Cochran <richardcochran@xxxxxxxxx>;
> > Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn
> > <andrew+netdev@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> > doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [Intel-wired-lan] [PATCH iwl-next v5 04/15] libeth: allow to
> > create fill queues without NAPI
> >
> > From: Pavan Kumar Linga <pavan.kumar.linga@xxxxxxxxx>
> >
> > Control queues can utilize libeth_rx fill queues, despite working
> > outside of NAPI context. The only problem is standard fill queues
> > requiring NAPI that provides them with the device pointer.
> >
> > Introduce a way to provide the device directly without using NAPI.
> >
> > Suggested-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
> > Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> > Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@xxxxxxxxx>
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
> > ---
> > drivers/net/ethernet/intel/libeth/rx.c | 9 +++++----
> > include/net/libeth/rx.h | 4 +++-
> > 2 files changed, 8 insertions(+), 5 deletions(-)
> >
>
> Tested-by: Bharath R <Bharath.r@xxxxxxxxx>

Tested-by: Samuel Salin <Samuel.salin@xxxxxxxxx>