Re: [PATCH net-next] r8152: Add 2500baseT EEE status/configuration support
From: Birger Koblitz
Date: Tue Feb 24 2026 - 12:33:15 EST
Hi Daniel,
On 24/02/2026 2:33 am, Daniel Golle wrote:
thanks for the feedback! You are of course right, the writing part was forgotten when editing the patch. I will send a corrected v2.tp->eee_en = eee->eee_enabled;
tp->eee_adv = val;
-
+ if (tp->support_2500full) {
+ val = linkmode_to_mii_eee_cap2_t(eee->advertised);
+ tp->eee_adv2 = val;
eee_adv2 set here is never actually written to the hardware.
ie. you are never doing
ocp_reg_write(tp, OCP_EEE_ADV2, tp->eee_adv2);
for capable NICs.
Birger