Re: [PATCH v2 0/3] staging: most: dim2: clean up error handling in fsl_mx6_enable

From: Greg Kroah-Hartman

Date: Tue Feb 24 2026 - 12:56:16 EST


On Tue, Feb 24, 2026 at 04:37:20AM +0000, Artem Lytkin wrote:
> This series cleans up error handling in fsl_mx6_enable(), split into
> separate logical changes per Dan Carpenter's review of v1.
>
> Changes since v1:
> - Split combined patch into 3 separate patches (one change per patch)
> - Extended string indirection fix to all three enable functions
>
> Patch 1 replaces IS_ERR_OR_NULL() with IS_ERR() since devm_clk_get()
> never returns NULL.
>
> Patch 2 replaces dev_err() + hardcoded -EFAULT with dev_err_probe()
> and PTR_ERR() to propagate correct error codes and handle probe
> deferral properly.
>
> Patch 3 removes unnecessary string indirection in dev_err() calls
> ("%s\n", "message" -> "message\n").
>
> Artem Lytkin (3):
> staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for
> devm_clk_get
> staging: most: dim2: use dev_err_probe and proper error codes for
> clock
> staging: most: dim2: remove unnecessary string indirection in dev_err
>
> drivers/staging/most/dim2/dim2.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> --
> 2.43.0
>

I see 2 different copies of this series, as can be seen on
lore.kernel.org:
https://lore.kernel.org/all/20260224043723.1828-1-iprintercanon@xxxxxxxxx/

which is "correct"?

Can you send a v3 so I know what to do?

thanks,

greg k-h