Re: [PATCH v3 4/8] nvme: always issue I/O Command Set specific Identify Namespace

[Keith Busch]

On Tue, Feb 24, 2026 at 10:14:33AM -0700, Caleb Sander Mateos wrote:
>  
> -	if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) {
> +	if (ns->ctrl->vs >= NVME_VS(2, 0, 0)) {
>  		ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm);

NVMe allows older spec compliant devices to implement features that came
later, so I think you need to keep the old condition as an option in
case there's a 1.4 controller with extended LBA formats.