Re: [Patch v6 10/22] perf/x86: Enable XMM Register Sampling for Non-PEBS Events

[Mi, Dapeng]

On 2/25/2026 3:13 AM, Chang S. Bae wrote:
> On 2/23/2026 11:11 PM, Mi, Dapeng wrote:
>> intent of this whole function is to sample the required SIMD and APX eGPRs
>> registers by leveraging xsaves instruction in a NMI handler context. All
>> the SIMD and eGPRs registers are collectively called "extended registers"
>> here. Not sure if the "extended registers" is a good word, please suggest
>> if there is a better one.
> They are sometimes referred as 'xregs' in short. Also this is a local 
> function. Following the do_something() style, perhaps just 
> update_xregs_state() or update_perf_xregs()

Thanks, 'xregs' is a good word. But considering current naming convention
in arch/x86/events/core.c, I would add the "x86_pmu" prefix and name the
function to "x86_pmu_sample_xregs". In the Perf/PMU context, "sample" is a
more precise word than "update".