Re: [PATCH] mm/cma: move put_page_testzero() out of VM_WARN_ON in cma_release()

[SeongJae Park]

On Tue, 24 Feb 2026 21:21:55 -0500 Zi Yan <ziy@xxxxxxxxxx> wrote:

> On 24 Feb 2026, at 21:20, SeongJae Park wrote:
> 
> > On Tue, 24 Feb 2026 18:18:44 -0800 SeongJae Park <sj@xxxxxxxxxx> wrote:
> >
> >> On Tue, 24 Feb 2026 16:39:46 -0500 Zi Yan <ziy@xxxxxxxxxx> wrote:
> >>
> >>> When CONFIG_DEBUG_VM is not set, VM_WARN_ON is a NOP. Putting any statement
> >>> with side effect inside it is incorrect. Move put_page_testzero() out and
> >>> check its return value in VM_WARN_ON. Add __maybe_unused to the return
> >>> value for when CONFIG_DEBUG_VM is not set.
> >>>
> >>> Fixes: 9bda131c6093 ("mm: cma: add cma_alloc_frozen{_compound}()")
> >>> Reported-by: Ron Economos <re@xxxxxxxx>
> >>> Closes: https://lore.kernel.org/all/1b17c38f-30d3-4bb4-a7e1-e74b19ada885@xxxxxxxx/
> >
> > I forgot asking this, sorry.
> >
> > Should we Cc stable@ ?
> 
> The commit is just in 7.0-rc1. Nothing is needed for stable.

Ack.


Thanks,
SJ

[...]