Re: [PATCH v3] bpf: cpumap: add missing XDP_ABORTED handling in xdp prog runner
From: Alexei Starovoitov
Date: Tue Feb 24 2026 - 23:06:48 EST
On Tue, Feb 17, 2026 at 8:29 PM Anand Kumar Shaw
<anandkrshawheritage@xxxxxxxxx> wrote:
>
> cpu_map_bpf_prog_run_xdp() handles XDP_PASS, XDP_REDIRECT, and
> XDP_DROP but is missing an XDP_ABORTED case. Without it, XDP_ABORTED
> falls into the default case which logs a misleading "invalid XDP
> action" warning instead of tracing the abort via trace_xdp_exception().
>
> Add the missing XDP_ABORTED case with trace_xdp_exception(), matching
> the handling already present in the skb path (cpu_map_bpf_prog_run_skb),
> devmap (dev_map_bpf_prog_run), and the generic XDP path (do_xdp_generic).
>
> Also pass xdpf->dev_rx instead of NULL to bpf_warn_invalid_xdp_action()
> in the default case, so the warning includes the actual device name.
> This aligns with the generic XDP path in net/core/dev.c which already
> passes the real device.
>
> Signed-off-by: Anand Kumar Shaw <anandkrshawheritage@xxxxxxxxx>
> ---
> Changes in v3:
> - Dropped unrelated queue_index changes that were accidentally
> included in v2
Toke, Jesper,
please review.