Re: [PATCH 12/21] staging: rtl8723bs: hal: fix line lengths in rtl8723b_hal_init.c
From: Dan Carpenter
Date: Wed Feb 25 2026 - 02:23:27 EST
On Tue, Feb 24, 2026 at 02:27:39PM +0100, luka.gejak@xxxxxxxxx wrote:
> @@ -998,9 +1008,13 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter)
> rtw_write32(padapter, REG_TCR, value32);
>
> /* NOTE: Fix test chip's bug (about contention windows's randomness) */
> - if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER_STATE|WIFI_AP_STATE) == true) {
> - rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50);
> - rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50);
> + {
> + u16 state_mask = WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE | WIFI_AP_STATE;
> +
> + if (check_fwstate(&padapter->mlmepriv, state_mask)) {
> + rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50);
> + rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50);
> + }
> }
I'm done reviewing the patchset for now.
regards,
dan carpenter