Re: [PATCH] KVM: TDX: Set SIGNIFCANT_INDEX flag for supported CPUIDs

From: Binbin Wu

Date: Wed Feb 25 2026 - 10:05:44 EST




On 2/25/2026 9:59 PM, Sean Christopherson wrote:
> On Wed, Feb 25, 2026, Binbin Wu wrote:
>> Do we need to consider the panic_on_warn case? I guess the option will not be
>> enabled in a production environment?
>
> Nope. That's even explicitly called out in Documentation/process/coding-style.rst:

Thanks for the info, and sorry for not checking it before asking the question.

>
> Do not worry about panic_on_warn users
> **************************************
>
> A few more words about panic_on_warn: Remember that ``panic_on_warn`` is an
> available kernel option, and that many users set this option. This is why
> there is a "Do not WARN lightly" writeup, above. However, the existence of
> panic_on_warn users is not a valid reason to avoid the judicious use
> WARN*(). That is because, whoever enables panic_on_warn has explicitly
> asked the kernel to crash if a WARN*() fires, and such users must be
> prepared to deal with the consequences of a system that is somewhat more
> likely to crash.
>