Re: [PATCH v2 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO

[Yedaya Katsman]

On Tue, 24 Feb 2026 at 09:27, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Mon, Feb 23, 2026 at 10:26:20PM +0200, Yedaya Katsman wrote:
> > Document Samsung S6E8FCO 6.09" 720x1560 panel
> > found in the Xiaomi Mi A3 smartphone.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Will do in the next version
> >
> > Co-developed-by: Kamil Gołda <kamil.golda@xxxxxxxxxxxxxx>
> > Signed-off-by: Kamil Gołda <kamil.golda@xxxxxxxxxxxxxx>
> > Signed-off-by: Yedaya Katsman <yedaya.ka@xxxxxxxxx>
> > ---
> >  .../bindings/display/panel/samsung,s6e8fco.yaml    | 64 ++++++++++++++++++++++
> >  MAINTAINERS                                        |  5 ++
> >  2 files changed, 69 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..8c042ce5f65bf317df48e109d88ebdc87ef5d5ed
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8fco.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/samsung,s6e8fco.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Samsung S6E8FCO AMOLED Panel
> > +
> > +maintainers:
> > +  - Yedaya Katsman <yedaya.ka@xxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: samsung,s6e8fco
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vddio-supply: true
> > +  ldo-supply: true
>
> LDO is the name of the type of regulator. Why is it called as name of
> the supply?
Can you explain more what you mean? Do you mean to change the name of
the property? It seems that all the regulator properties are named
foo-supply.

> Isn't this binding exactly the same as s6e3ha8, s6e8aa5x01, sofef00 or
> any others?
Yeah they follow the same pattern. Is there something missing in this
one? I will add descriptions to foo-supply properties
> > +  iovcc-supply: true
>
>
> Best regards,
> Krzysztof
>