Re: [PATCH 10/21] staging: rtl8723bs: os_dep: fix line lengths in ioctl_cfg80211.c

[Greg Kroah-Hartman]

On Wed, Feb 25, 2026 at 04:17:20PM +0100, Luka Gejak wrote:
> On February 25, 2026 4:14:37 PM GMT+01:00, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >On Wed, Feb 25, 2026 at 04:08:02PM +0100, Luka Gejak wrote:
> >> On February 25, 2026 3:56:50 PM GMT+01:00, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >> >On Wed, Feb 25, 2026 at 09:58:07AM +0300, Dan Carpenter wrote:
> >> >> On Tue, Feb 24, 2026 at 02:27:37PM +0100, luka.gejak@xxxxxxxxx wrote:
> >> >> > From: Luka Gejak <luka.gejak@xxxxxxxxx>
> >> >> > 
> >> >> > Break long lines exceeding 100 characters to comply with kernel coding
> >> >> > style.
> >> >> > 
> >> >> > Signed-off-by: Luka Gejak <luka.gejak@xxxxxxxxx>
> >> >> > ---
> >> >> >  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 134 ++++++++++++------
> >> >> >  1 file changed, 94 insertions(+), 40 deletions(-)
> >> >> > 
> >> >> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> >> >> > index 51725c302458..c04af493f24d 100644
> >> >> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> >> >> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> >> >> > @@ -127,8 +127,10 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
> >> >> >  	if (!spt_band)
> >> >> >  		goto exit;
> >> >> >  
> >> >> > -	spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band) + sizeof(struct ieee80211_supported_band));
> >> >> > -	spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels) + sizeof(struct ieee80211_channel) * n_channels);
> >> >> > +	spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band) +
> >> >> > +			      sizeof(struct ieee80211_supported_band));
> >> >> > +	spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels) +
> >> >> > +			     sizeof(struct ieee80211_channel) * n_channels);
> >> >> >  	spt_band->band = band;
> >> >> >  	spt_band->n_channels = n_channels;
> >> >> >  	spt_band->n_bitrates = n_bitrates;
> >> >> > @@ -207,7 +209,8 @@ int rtw_ieee80211_channel_to_frequency(int chan)
> >> >> >  }
> >> >> >  
> >> >> >  #define MAX_BSSINFO_LEN 1000
> >> >> > -struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wlan_network *pnetwork)
> >> >> > +struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter,
> >> >> > +					     struct wlan_network *pnetwork)
> >> >> >  {
> >> >> >  	struct ieee80211_channel *notify_channel;
> >> >> >  	struct cfg80211_bss *bss = NULL;
> >> >> > @@ -248,7 +251,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wl
> >> >> >  		u32 wpsielen = 0;
> >> >> >  		u8 *wpsie = NULL;
> >> >> >  
> >> >> > -		wpsie = rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wpsielen);
> >> >> > +		u8 *ies = pnetwork->network.ies + _FIXED_IE_LENGTH_;
> >> >> > +		uint ie_len = pnetwork->network.ie_length - _FIXED_IE_LENGTH_;
> >> >> > +
> >> >> 
> >> >> No spaces in the middle of a declaration block, please.
> >> >
> >> >Wait, that's not described in the changelog either!
> >> >
> >> >I'll go just drop this whole series, thanks Dan for the better review
> >> >than I gave it.  I'll blame the jet-lag...
> >> >
> >> >thanks,
> >> >
> >> >greg k-h
> >> 
> >> Hi Greg, 
> >> What about 13 patches already in staging-testing?
> >
> >I just now dropped them all, sorry.
> >
> >Please rebase your whole series and resubmit.
> >
> >thanks,
> >
> >greg k-h
> 
> Should I make any modifications, per Dan's advice?

Yes, just always consider what Dan says is always correct, I sure do :)

So as-is, these patches are not ok and should be reworked.

thanks,

greg k-h