Re: [PATCH v8 4/8] dmaengine: sh: rz-dmac: Drop goto instruction and label

[Frank Li]

On Tue, Jan 20, 2026 at 03:33:26PM +0200, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> There is no need to jump to the done label just to return.
> Return immediately.

Nit: There is no need to jump to the done label, so return immediately.

I think vnod can change it when apply.

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
>
> Changes in v8:
> - none
>
> Changes in v7:
> - none
>
> Changes in v6:
> - none, this patch is new
>
>  drivers/dma/sh/rz-dmac.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
> index bb9ca19cf784..cc540b35dc29 100644
> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -706,7 +706,7 @@ static void rz_dmac_irq_handle_channel(struct rz_dmac_chan *channel)
>
>  		scoped_guard(spinlock_irqsave, &channel->vc.lock)
>  			rz_dmac_ch_writel(channel, CHCTRL_DEFAULT, CHCTRL, 1);
> -		goto done;
> +		return;
>  	}
>
>  	/*
> @@ -714,8 +714,6 @@ static void rz_dmac_irq_handle_channel(struct rz_dmac_chan *channel)
>  	 * zeros to CHCTRL is just ignored by HW.
>  	 */
>  	rz_dmac_ch_writel(channel, CHCTRL_CLREND, CHCTRL, 1);
> -done:
> -	return;
>  }
>
>  static irqreturn_t rz_dmac_irq_handler(int irq, void *dev_id)
> --
> 2.43.0
>