Re: [PATCH v3] mm/cma: move put_page_testzero() out of VM_WARN_ON in cma_release()
From: Vishal Moola (Oracle)
Date: Wed Feb 25 2026 - 12:24:19 EST
On Tue, Feb 24, 2026 at 10:12:31PM -0500, Zi Yan wrote:
> When CONFIG_DEBUG_VM is not set, VM_WARN_ON is a NOP. Putting any statement
> with side effect inside it is incorrect. Collect all !put_page_testzero()
> results and check the sum using WARN instead after the loop. It restores
> the same check in free_contig_range() before commit
> e0c1326779cc ("mm: page_alloc: add alloc_contig_frozen_{range,pages}()"),
> the commit prior to the Fixes one.
LGTM.
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@xxxxxxxxx>