Re: Re: [PATCH v3] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation
From: Conor Dooley
Date: Wed Feb 25 2026 - 12:57:30 EST
On Wed, Feb 25, 2026 at 11:24:29AM +0800, Huan He wrote:
> > > The binding defines tuple-style reset-names items for some
> > > compatibles, which implicitly enforces a fixed array length
> > > via JSON Schema.
> > >
> > > Defining global maxItems for resets and reset-names causes these
> > > constraints to be intersected via allOf, resulting in an effective
> > > minItems equal to the global maxItems. This leads to dtbs_check
> > > failures reporting reset arrays as too short, even when the DTS
> > > provides the correct number of entries.
> > >
> > > Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
> > > Signed-off-by: Pritesh Patel <pritesh.patel@xxxxxxxxxxxxxx>
> > > Signed-off-by: Huan He <hehuan1@xxxxxxxxxxxxxxxxxx>
> >
> > Signoff chain looks wrong. You're author and submitter, what did
> > Pritesh do?
>
> Thank you very much for taking the time to review the patch and for your
> valuable feedback.
>
> Internally, Pritesh provided the initial version of this fix, and I have
> made subsequent updates and refinements before submitting it to the
> community.
Then you need to add a Co-developed-by tag for them in addition to the
Signed-off-by.
Attachment:
signature.asc
Description: PGP signature