Re: [PATCH 4/4] misc: pci_endpoint_test: Add Tegra194 and Tegra234 device table entries

[Niklas Cassel]

On Wed, Feb 25, 2026 at 06:59:02PM +0100, Niklas Cassel wrote:
> On Mon, Feb 23, 2026 at 01:04:56AM +0530, Manikanta Maddireddy wrote:
> > Add PCI device IDs and test data for Tegra194 (0x1ad4) and Tegra234
> > (0x229b) endpoints so pci_endpoint_test can bind and run on these
> > controllers (64K BAR alignment).
> > 
> > Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
> > ---
> >  drivers/misc/pci_endpoint_test.c | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> > index f166b6fea698..43545dbad26f 100644
> > --- a/drivers/misc/pci_endpoint_test.c
> > +++ b/drivers/misc/pci_endpoint_test.c
> > @@ -106,6 +106,9 @@
> >  
> >  #define PCI_DEVICE_ID_ROCKCHIP_RK3588		0x3588
> >  
> > +#define PCI_DEVICE_ID_NVIDIA_TEGRA194_EP	0x1ad4
> > +#define PCI_DEVICE_ID_NVIDIA_TEGRA234_EP	0x229b
> > +
> >  static DEFINE_IDA(pci_endpoint_test_ida);
> >  
> >  #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \
> > @@ -1202,6 +1205,10 @@ static const struct pci_endpoint_test_data rk3588_data = {
> >  	.alignment = SZ_64K,
> >  };
> >  
> > +static const struct pci_endpoint_test_data tegra_ep_data = {
> > +	.alignment = SZ_64K,
> > +};
> 
> An explcit .alignment is not needed anymore, it was only needed before we
> introduced capabilities. New entries should be added without an explicit
> alignment, since it will be provided by the capabilties register.

Sorry, small clarification:
Allocating extra large buffers on the host side (.alignment) is not needed
anymore, since pci-epf-test (the endpoint side) nowadays can do unaligned
accesses using pci_epc_mem_map()/unmap().

See:
ce1dfe6d3289 ("PCI: endpoint: Introduce pci_epc_mem_map()/unmap()")
08cac1006bfc ("PCI: endpoint: test: Use pci_epc_mem_map/unmap()")
8a02612f8566 ("PCI: endpoint: pci-epf-test: Add support for capabilities")


Kind regards,
Niklas