Re: [PATCH v3 next 06/17] tools/nolibc/printf: Change variables 'c' to 'ch' and 'tmpbuf[]' to 'outbuf[]'

From: Thomas Weißschuh

Date: Wed Feb 25 2026 - 17:23:17 EST


On 2026-02-23 10:17:24+0000, david.laight.linux@xxxxxxxxx wrote:
> From: David Laight <david.laight.linux@xxxxxxxxx>
>
> Changing 'c' makes the code slightly easier to read because the variable
> stands out from the single character literals (especially 'c').
>
> Change tmpbuf[] to outbuf[] because 'out' points into it.
>
> The following patches pretty much rewrite the function so the
> churn is limited.
>
> Acked-by: Willy Tarreau <w@xxxxxx>
> Acked-by: "Thomas Weißschuh" <linux@xxxxxxxxxxxxxx>
> Signed-off-by: David Laight <david.laight.linux@xxxxxxxxx>

Applied, thanks. I applied it out-of-order and fixed it up to get it out
of the way.

FYI I won't finish the whole review today and for the meaty new bits
Willy will also want to take a look.

(...)