Re: [PATCH v3 2/3] clk: qcom: Add a driver for SM8750 GPU clocks

[Taniya Das]

On 2/23/2026 3:06 AM, Dmitry Baryshkov wrote:
> On Fri, Feb 20, 2026 at 11:24:21AM +0530, Taniya Das wrote:
>> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>>
>> Support the graphics clock controller for SM8750 for Graphics SW
>> driver to use the clocks. GXCLKCTL (Graphics GX Clock Controller) is a
>> block dedicated to managing clocks for the GPU subsystem on GX power
>> domain. The GX clock controller driver manages only the GX GDSC and the
>> rest of the resources of the controller are managed by the firmware.
> 
> You missed patches for the gxclkctl driver.
> 

Yes, my bad :(, I missed committing the change.

>>
>> Update the compatible for Graphics GX Clock Controller for SM8750 as the
>> GX clock controller is a reuse of the Kaanapali driver.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>> Co-developed-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
>> ---
>>  drivers/clk/qcom/Kconfig        |   9 +
>>  drivers/clk/qcom/Makefile       |   1 +
>>  drivers/clk/qcom/gpucc-sm8750.c | 472 ++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 482 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
>> index 6b0ad8832b55f1914079f15323b8cdd1608ad4c0..817b13f5e78cb534e165b09d95e70cd4a58b12bd 100644
>> --- a/drivers/clk/qcom/Makefile
>> +++ b/drivers/clk/qcom/Makefile
>> @@ -180,6 +180,7 @@ obj-$(CONFIG_SM_GPUCC_8350) += gpucc-sm8350.o
>>  obj-$(CONFIG_SM_GPUCC_8450) += gpucc-sm8450.o
>>  obj-$(CONFIG_SM_GPUCC_8550) += gpucc-sm8550.o
>>  obj-$(CONFIG_SM_GPUCC_8650) += gpucc-sm8650.o
>> +obj-$(CONFIG_SM_GPUCC_8750) += gpucc-sm8750.o gxclkctl-kaanapali.o
> 
> I think, If both drivers are built-in, this will result in the object
> file being added twice and, thus, a conflict.

I have tried compiling both kaanapali and sm8750 as built-in drivers and
I do not see any conflict. Please let me know if I am missing something
here.

> 
>>  obj-$(CONFIG_SM_GPUCC_MILOS) += gpucc-milos.o
>>  obj-$(CONFIG_SM_LPASSCC_6115) += lpasscc-sm6115.o
>>  obj-$(CONFIG_SM_TCSRCC_8550) += tcsrcc-sm8550.o
> 

-- 
Thanks,
Taniya Das