Re: [PATCH] drm/solomon: Fix page start when updating rectangle in page addressing mode

[Javier Martinez Canillas]

Francesco Lavra <flavra@xxxxxxxxxxxx> writes:

Hello Francesco,

Thanks for the patch!

> In page addressing mode, the pixel values of a dirty rectangle must be sent
> to the display controller one page at a time. The range of pages
> corresponding to a given rectangle is being incorrectly calculated as if
> the Y value of the top left coordinate of the rectangle was 0. This can
> result in rectangle updates being displayed on wrong parts of the screen.
>
> Fix the above issue by consolidating the start page calculation in a single
> place at the beginning of the update_rect function, and using the
> calculated value for all addressing modes.
>
> Fixes: b0daaa5cfaa5 ("drm/ssd130x: Support page addressing mode")
> Signed-off-by: Francesco Lavra <flavra@xxxxxxxxxxxx>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat