Re: [PATCH 0/3] net: ntb_netdev: Add Multi-queue support

From: Koichiro Den

Date: Thu Feb 26 2026 - 03:05:14 EST


On Wed, Feb 25, 2026 at 07:50:04PM -0800, Jakub Kicinski wrote:
> On Wed, 25 Feb 2026 00:28:06 +0900 Koichiro Den wrote:
> > Usage (example):
> > - modprobe ntb_netdev ntb_num_queues=<N> # Patch 2 takes care of it
> > - ethtool -l <ifname> # Patch 3 takes care of it
>
> Module parameters are not a very user friendly choice for uAPI.
> You use ethtool -l for GET, what's the challenge with implementing SET
> via ethtool -L?

Thanks for the comment, Jakub.

There is no technical limitation. I didn't include SET support simply to keep
the initial series minimal as possible.

However, you're right, adding such a module parameter would also make it part of
the uAPI and unnecesarily hard to remove later. It's better to implement SET
from the beggining.

Dave, let me respin the series with SET support and drop the module parameter.
Please let me know if you have any objections.

Best regards,
Koichiro