Re: [PATCH v1 5/8] dt-bindings: hwmon: add NXP MC33978/MC34978 hwmon
From: Krzysztof Kozlowski
Date: Thu Feb 26 2026 - 03:17:52 EST
On Wed, Feb 25, 2026 at 06:15:38PM +0100, Oleksij Rempel wrote:
> Add device tree binding documentation for the hardware monitoring block
> of the NXP MC33978/MC34978 Multiple Switch Detection Interface (MSDI).
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
> .../bindings/hwmon/nxp,mc33978-hwmon.yaml | 34 +++++++++++++++++++
> .../devicetree/bindings/mfd/nxp,mc33978.yaml | 10 ++++++
> 2 files changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/nxp,mc33978-hwmon.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/nxp,mc33978-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/nxp,mc33978-hwmon.yaml
> new file mode 100644
> index 000000000000..b7e2aaa51a33
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/nxp,mc33978-hwmon.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/nxp,mc33978-hwmon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP MC33978/MC34978 Hardware Monitor
> +
> +maintainers:
> + - David Jander <david@xxxxxxxxxxx>
> + - Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> +
> +description: |
> + Hardware monitoring driver for the MC33978/MC34978 MSDI device.
> + Provides fault detection and monitoring for:
> + - Battery voltage (VBATP) faults: undervoltage, overvoltage
> + - Temperature faults: over-temperature, warning threshold
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,mc33978-hwmon
> + - nxp,mc34978-hwmon
> +
> +required:
> + - compatible
This is completely empty thus pointless. Do not create nodes which has 0
properties (compatible does not count since it is used to tell what the
device is).
Best regards,
Krzysztof