Re: [PATCH 02/13] libmultipath: Add basic gendisk support

[John Garry]

On 26/02/2026 02:16, Benjamin Marzinski wrote:
> > struct mpath_head_template is introduced as a method for drivers to
> > provide custom multipath functionality.
> >
> > Signed-off-by: John Garry<john.g.garry@xxxxxxxxxx>
> > ---
> > +
> > +void mpath_device_set_live(struct mpath_disk *mpath_disk,
> > +			struct mpath_device *mpath_device)
> > +{
> > +	struct mpath_head *mpath_head = mpath_disk->mpath_head;
> You're dereferencing mpath_disk here, before the check if it's NULL.
>
> -Ben
>
> > +	int ret;
> > +
> > +	if (!mpath_disk)

Yeah, this NULL check is not needed.

Thanks!