Re: [PATCH v1 1/1] gpio: generic: Don't use 'proxy' headers

[Bartosz Golaszewski]

On Thu, Feb 26, 2026 at 10:20 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpio/gpio-mmio.c     | 4 +---
>  include/linux/gpio/generic.h | 8 +++++++-
>  2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
> index edbcaad57d00..0941d034a49c 100644
> --- a/drivers/gpio/gpio-mmio.c
> +++ b/drivers/gpio/gpio-mmio.c
> @@ -42,18 +42,16 @@ o        `                     ~~~~\___/~~~~    ` controller in FPGA is ,.`
>
>  #include <linux/bitops.h>
>  #include <linux/cleanup.h>
> -#include <linux/compiler.h>
>  #include <linux/err.h>
> -#include <linux/init.h>
>  #include <linux/io.h>
>  #include <linux/ioport.h>
> +#include <linux/limits.h>
>  #include <linux/log2.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
> -#include <linux/slab.h>

In that case don't we need device.h for devm_kzalloc()?

Bart

>  #include <linux/spinlock.h>
>  #include <linux/types.h>
>
> diff --git a/include/linux/gpio/generic.h b/include/linux/gpio/generic.h
> index ff566dc9c3cb..de43c06c83ef 100644
> --- a/include/linux/gpio/generic.h
> +++ b/include/linux/gpio/generic.h
> @@ -3,9 +3,15 @@
>  #ifndef __LINUX_GPIO_GENERIC_H
>  #define __LINUX_GPIO_GENERIC_H
>
> +#include <linux/bits.h>
> +#include <linux/bug.h>
>  #include <linux/cleanup.h>
> -#include <linux/gpio/driver.h>
> +#include <linux/container_of.h>
> +#include <linux/errno.h>
>  #include <linux/spinlock.h>
> +#include <linux/types.h>
> +
> +#include <linux/gpio/driver.h>
>
>  struct device;
>
> --
> 2.50.1
>