Re: [PATCH RESEND v2 1/5] media: dt-bindings: Add CAMSS device for SM8750
From: Krzysztof Kozlowski
Date: Thu Feb 26 2026 - 05:05:52 EST
On 20/01/2026 07:42, Hangxiang Ma wrote:
> Add bindings for Camera Subsystem (CAMSS) on the Qualcomm SM8750 platform.
>
> The SM8750 platform provides:
>
> - 3 x VFE (Video Front End), 5 RDI per VFE
> - 2 x VFE Lite, 4 RDI per VFE Lite
> - 3 x CSID (CSI Decoder)
> - 2 x CSID Lite
> - 6 x CSIPHY (CSI Physical Layer)
> - 2 x ICP (Image Control Processor)
> - 1 x IPE (Image Processing Engine)
> - 2 x JPEG DMA & Downscaler
> - 2 x JPEG Encoder
> - 1 x OFE (Offline Front End)
> - 5 x RT CDM (Camera Data Mover)
> - 3 x TPG (Test Pattern Generator)
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Hangxiang Ma <hangxiang.ma@xxxxxxxxxxxxxxxx>
> ---
> .../bindings/media/qcom,sm8750-camss.yaml | 663 +++++++++++++++++++++
> 1 file changed, 663 insertions(+)
Same comment as here:
https://lore.kernel.org/r/7927bdab-9c3b-460d-a2ba-2e5b06ee8804@xxxxxxxxxx/
Pasting for reference:
Just to be clear, because Bryan posted now x1e80100 camss patches
changing ABI. I was holding this patchset for camss/media maintainers to
come up with driver and any other necessary pieces (like guidance for
bindings) support for split CSI PHY. Finally after long time I gave up
and gave these bindings green light.
Additionally there is some claim that there is policy allowing to change
bindings. No. There is no change of bindings with few exceptions. Decide
now what bindings you want to have. One single node or split CSI PHY,
because you cannot take the first option but then six months later send
complete revamp of the ABI.
So please decide and answer, e.g. by taking this patch, that you
understand above and THIS will be your fixed ABI.
Best regards,
Krzysztof