Re: [PATCH v7 20/23] scsi: ufs: mediatek: Back up idle timer in per-instance struct

[AngeloGioacchino Del Regno]

Il 26/02/26 04:46, Peter Wang (王信友) ha scritto:
> On Wed, 2026-02-25 at 13:40 +0100, AngeloGioacchino Del Regno wrote:
> > In my opinion "ahit" is way less readable than
> > "hibernate_idle_timer".
> >
> > The hibernate_idle_timer member here stores the AUTO HIBERNATE IDLE
> > TIMER, and
> > there is no other possible hibernation state in this driver.
> >
> > Not sure why this could ever be confusing in terms of its intended
> > use: its
> > intended use is to store the (auto) hibern8 idle timer, and the
> > member is called
> > hibernate_idle_timer.
> >
> > In my eyes, that matches 1:1 with its usage. Loud and clear.
> >
> > Regards,
> > Angelo
>
> Hi AngeloGioacchino,
>
> If you want to refer to the AUTO HIBERNATE IDLE TIMER,
> then you cannot omit "auto" because the UFS driver also
> has a manual hibernate method.
> However, "AUTO HIBERNATE IDLE TIMER" is too long,
> and we often use "ahit" instead (which is also used in
> the UFSHCI spec). For example:
> https://elixir.bootlin.com/linux/v6.19.3/source/include/ufs/ufshcd.h#L978
>
> So, if you want to distinguish it from hba->ahit, I suggest
> using backup_ahit or saved_ahit instead.

Okay, does "saved_auto_hibern8_idle_tmr" sound good for you instead?

Regards,
Angelo

> Thanks
> Peter