Re: [PATCH v2 2/3] drm: panel: Add Samsung S6E8FCO

[Yedaya Katsman]

On Wed, 25 Feb 2026 at 23:24, David Heidelberg <david@xxxxxxx> wrote:
>
> On 25/02/2026 22:13, Yedaya Katsman wrote:
>
>
> [...]
> >>> +static struct backlight_device *
> >>> +s6e8fco_samsungp_create_backlight(struct mipi_dsi_device *dsi)
> >>> +{
> >>> +     struct device *dev = &dsi->dev;
> >>> +     const struct backlight_properties props = {
> >>> +             .type = BACKLIGHT_RAW,
> >>> +             .brightness = 268,
> >>
> >> ~ 10% of brightness at boot? What is the scale? Shouldn't make sense to
> >> set it around 50%? (just asking)
> > This is just what was configured downstream, it looks bright enough for me
> > fwiw, I can change it if you want.
>
> No need to change it if it’s bright enough. If it’s usable when you
> power on the device outdoors with some daylight exposure, then it’s fine.
While testing this I found out that the max brightness is actually
1023, anything
above 1024 just wraps around, i.e 1224 is the same as 200. Will update the
max to be 1023.
I tested outside and it is a bit hard to see, will update the default to 512.

> Also, since the user can adjust the brightness later, it won’t matter
> much either way.
>
> Thanks,
> David
>
> [...]

Thank,
Yedaya