Re: [PATCH 2/2] misc: ti_fpc202: remove dead code in fpc202_detach_addr()

[Romain Gantois]

On Friday, 20 February 2026 18:20:32 CET Felix Gu wrote:
> val is assigned from addr_caches, which is a u8 array. So the check will
> never be true.
> 
> Found by code review, compile pass.
> 
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> ---
> 
>  drivers/misc/ti_fpc202.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index 578feefb77f1..79a029d79f7a 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -243,23 +243,15 @@ static void fpc202_detach_addr(struct i2c_atr *atr,
> u32 chan_id, u16 addr)
> 
>  {
>  
>  	struct fpc202_priv *priv = i2c_atr_get_driver_data(atr);
> 
> -	int dev_num, reg_mod, val;
> +	int dev_num, val;
> 
>  	for (dev_num = 0; dev_num < 2; dev_num++) {
> 
> -		reg_mod = FPC202_REG_MOD_DEV(chan_id, dev_num);
> -
> 
>  		mutex_lock(&priv->reg_dev_lock);
>  		
>  		val = priv->addr_caches[chan_id][dev_num];
>  		
>  		mutex_unlock(&priv->reg_dev_lock);
> 
> -		if (val < 0) {
> -			dev_err(&priv->client->dev, "failed to read register 
0x%x while
> detaching address 0x%02x\n", -				reg_mod, addr);
> -			return;
> -		}
> -
> 
>  		if (val == (addr & 0x7f)) {
>  		
>  			fpc202_write_dev_addr(priv, chan_id, dev_num, 
FPC202_REG_DEV_INVALID);
>  			return;

Reviewed-by: Romain Gantois <romain.gantois@xxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part.