Re: [PATCH net 2/2] amd-xgbe: add PCI power management for S0i3 support

From: Rangoju, Raju

Date: Thu Feb 26 2026 - 10:57:52 EST




On 2/26/2026 6:08 PM, Simon Horman wrote:

---
drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 39 ++++++++++++++++++++++++
1 file changed, 39 insertions(+)

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
index 112d7697174c..8e392cccd065 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
@@ -356,15 +356,34 @@ static int xgbe_pci_suspend(struct device *dev)
{
struct xgbe_prv_data *pdata = dev_get_drvdata(dev);
struct net_device *netdev = pdata->netdev;
+ struct pci_dev *pdev = to_pci_dev(dev);
int ret = 0;

+ if (!netdev)
+ return 0;
+

Can netdev be NULL here?
Same question for the check in xgbe_pci_resume().

Sure Simon, will fix it and submit to net-next as this patch is an enhancement.