Re: [PATCH net-next 5/7] bng_en: add initial support for ethtool stats display
From: Bhargava Chenna Marreddy
Date: Thu Feb 26 2026 - 12:27:11 EST
On Wed, Feb 25, 2026 at 2:43 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > Thanks for pointing this out. We'll review the stats and map them to
> > the appropriate structured callbacks (.get_rmon_stats, .get_eth_phy_stats,
> > .get_eth_mac_stats & .get_eth_ctrl_stats).
> > To make sure we get v2 right -- should these stats be moved entirely to
> > the structured callbacks, or should they remain in .get_ethtool_stats as well?
>
> .get_ethtool_stats should only be used for anything which does not fit
> any other calls.
>
> Andrew
Hi Andrew, thanks for the clarification; I will address this in the next spin.
Thanks,
Bhargava Marreddy
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature