Re: [PATCH 2/3] hv_balloon: Change default page reporting order

[David Hildenbrand (Arm)]

On 2/26/26 08:01, Yuvraj Sakshith wrote:
> page_reporting_order used to fall back to default
> value (passed as parameter or MAX_PAGE_ORDER) if
> the driver wishes to not provide it.
> 
> The way the driver used to do this was by passing
> the order as zero.
> 
> Now that zero is a valid order that can be passed by
> a driver to page reporting, we use -1 to signal
> default value to be used.
> 
> Signed-off-by: Yuvraj Sakshith <yuvraj.sakshith@xxxxxxxxxxxxxxxx>
> ---
>  drivers/hv/hv_balloon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> index 2b4080e51..e33d6e3b2 100644
> --- a/drivers/hv/hv_balloon.c
> +++ b/drivers/hv/hv_balloon.c
> @@ -1663,7 +1663,7 @@ static void enable_page_reporting(void)
>  	 * We let the page_reporting_order parameter decide the order
>  	 * in the page_reporting code
>  	 */
> -	dm_device.pr_dev_info.order = 0;
> +	dm_device.pr_dev_info.order = -1;
>  	ret = page_reporting_register(&dm_device.pr_dev_info);
>  	if (ret < 0) {
>  		dm_device.pr_dev_info.report = NULL;

Logically, that patch must come before #1. And the patch description
should be rephrased to clarify that we want to change that behavior.

Reviewed-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

-- 
Cheers,

David