Re: [RESEND PATCH] ice: access @pp through netmem_desc instead of page

[Tony Nguyen]

On 2/25/2026 5:08 PM, Byungchul Park wrote:
> On Tue, Feb 24, 2026 at 02:35:46PM +0900, Byungchul Park wrote:
> > To eliminate the use of struct page in page pool, the page pool users
> > should use netmem descriptor and APIs instead.
> >
> > Make ice driver access @pp through netmem_desc instead of page.
>
> Hi Tony and Przemek,
>
> Is there something that I'm missing or something wrong with this?  Your
> feedback would be appreciated.  Thanks!

Hi Byungchul,

Nothing wrong. I plan to apply it today.

Thanks,
Tony

> 	Byungchul
>
> > Signed-off-by: Byungchul Park <byungchul@xxxxxx>
> > ---
> >   drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > index c6bc29cfb8e6..c16e54dbe75b 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
> >   		rx_buf = &rx_ring->rx_fqes[i];
> >   		page = __netmem_to_page(rx_buf->netmem);
> >   		received_buf = page_address(page) + rx_buf->offset +
> > -			       page->pp->p.offset;
> > +			       pp_page_to_nmdesc(page)->pp->p.offset;
> >   
> >   		if (ice_lbtest_check_frame(received_buf))
> >   			valid_frames++;
> > --
> > 2.17.1