Re: [PATCH v2 1/3] vfio/pci: Rename vfio_config_do_rw() to vfio_pci_config_rw_single() and export it
From: Niklas Schnelle
Date: Thu Feb 26 2026 - 14:45:06 EST
On Tue, 2026-02-24 at 13:34 +0100, Julian Ruess wrote:
> A follow-up patch adds a new variant driver for s390 ISM devices. Since
> this device uses a 256 TiB BAR 0 that is never mapped, the variant
> driver needs its own ISM_VFIO_PCI_OFFSET_MASK. To minimally mirror the
> functionality of vfio_pci_config_rw() with such a custom mask, export
> vfio_config_do_rw(). To better distinguish the now exported function
> from vfio_pci_config_rw(), rename it to vfio_pci_config_rw_single()
> emphasizing that it does a single config space read or write.
>
> Signed-off-by: Julian Ruess <julianr@xxxxxxxxxxxxx>
> ---
> drivers/vfio/pci/vfio_pci_config.c | 8 +++++---
> drivers/vfio/pci/vfio_pci_priv.h | 4 ++++
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
Looks good to me, thanks!
Reviewed-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>