Re: [PATCH v1] ALSA: aoa: Constify struct configfs_item_operations and configfs_group_operations

From: Christophe JAILLET

Date: Thu Feb 26 2026 - 15:58:27 EST


Le 26/02/2026 à 21:47, Johannes Berg a écrit :
On Thu, 2026-02-26 at 21:43 +0100, Christophe JAILLET wrote:
'struct codec_connection' are not modified in this driver.

Constifying these structures moves some data to a read-only section, so
increases overall security.


The security claim seems like a stretch for this data, but I guess since
it's never modified making it const makes some sense.

You are right, in this case the security claim is a bit too much.
I use the same template for all such patches, and some times, it is less relevant.

The claim makes much more sense when the struct has some function pointers.


Please not the the subject is broken (configfs_item_operations...)
I've sent the same patch with the correct subject.
Sorry for the noise.

CJ



johannes