Re: [PATCH v4 4/8] nvme: always issue I/O Command Set specific Identify Namespace
From: Keith Busch
Date: Thu Feb 26 2026 - 16:02:59 EST
On Thu, Feb 26, 2026 at 12:04:11PM -0700, Caleb Sander Mateos wrote:
> - if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) {
> - ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm);
> - if (ret < 0)
> - goto out;
> - }
> + ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm);
> + if (ret < 0)
> + goto out;
I don't think we can do this identify unconditionally. The controller
has to at least pass nvme_id_cns_ok().