Re: [PATCH 1/6] arm64: dts: amlogic: meson-s4: add UART_A node

[Martin Blumenstingl]

Hi Nick,

On Fri, Jan 23, 2026 at 3:23 AM Nick Xie <nick@xxxxxxxxxx> wrote:
[...]
> +                               a_uart_pins: a_uart {
> +                                       mux {
> +                                               groups = "uart_a_tx",
> +                                                      "uart_a_rx",
> +                                                      "uart_a_cts",
> +                                                      "uart_a_rts";
> +                                               function = "uart_a";
> +                                       };
> +                               };
Can we please keep the split between rx/tx and rts/cts pins (as we
have it on other SoCs)?
It is likely that many boards follow the same path as Khadas VIM1S
(and Amlogic's reference design). For those boards that aren't it
would be great if they don't have to update meson-s4.dtsi.

>                                 i2c0_pins1: i2c0-pins1 {
>                                         mux {
>                                                 groups = "i2c0_sda",
> @@ -814,6 +824,18 @@ mdio0: mdio {
>                         };
>                 };
>
> +               uart_a: serial@fe078000 {
> +                       compatible = "amlogic,meson-s4-uart",
> +                                    "amlogic,meson-ao-uart";
> +                       reg = <0x0 0xfe078000 0x0 0x18>;
> +                       interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> +                       clocks = <&xtal>, <&clkc_periphs CLKID_UART_A>, <&xtal>;
> +                       clock-names = "xtal", "pclk", "baud";
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&a_uart_pins>;
For consistency I also prefer if you could move this to
meson-s4-s905y4-khadas-vim1s.dts (patch 2)


Thank you!
Martin