Re: [PATCH 5/6] arm64: dts: amlogic: meson-s4: add internal SARADC controller

[Martin Blumenstingl]

Hi Nick,

On Fri, Jan 23, 2026 at 3:23 AM Nick Xie <nick@xxxxxxxxxx> wrote:
[...]
> +       saradc: adc@fe026000 {
> +               compatible = "amlogic,meson-g12a-saradc",
> +                            "amlogic,meson-saradc";
It seems that the engineers at Amlogic are constantly updating the SARADC core.
To avoid any problems in the future, can you please add a new
compatible string for the s4-saradc?
For reference you can take a look at:
- commit e415a1659ec9 ("iio: adc: meson-saradc: add support for Meson
G12A") which added the g12a compatible string to the driver (note that
meson_sar_adc_gxl_param since then has been replaced by
meson_sar_adc_g12a_param - you can re-use the latter)
- commit b2729cdf2bc0 ("dt-bindings: iio: adc: amlogic,meson-saradc:
Add GXLX SoC compatible") which documented a new compatible string in
the dt-bindings

I think it is best to do this in a separate series.

In case we discover anything that needs changing in the SARADC driver in future:
Having a dedicated compatible string means we can just update the
driver and be done with it.
One example where this has happened for G12A is commit 48dc1abde015
("iio: adc: meson-saradc: Disable BL30 integration on G12A and newer
SoCs").


Thank you!
Martin