Re: [PATCH v4 3/3] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer

[Google]

On Thu, 26 Feb 2026 12:36:55 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Thu, 26 Feb 2026 21:58:33 +0900
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:
> 
> > > --- a/kernel/trace/ring_buffer.c
> > > +++ b/kernel/trace/ring_buffer.c
> > > @@ -2058,17 +2058,18 @@ static void rb_meta_validate_events(struct ring_buffer_per_cpu *cpu_buffer)
> > >  		if (ret < 0) {
> > >  			pr_info("Ring buffer meta [%d] invalid buffer page\n",
> > >  				cpu_buffer->cpu);  
> > 
> > This pr_info() should be removed too, because multiple pages
> > can be discarded.
> 
> I wouldn't discard it, but instead add a "once" variable, where it shows it
> only once per CPU.

OK, let me update it. 

Thanks!

> 
> -- Steve


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>