Re: [PATCH v2] remoteproc: qcom_wcnss: Fix handling the lack of PD regulators in v3

From: Val Packett

Date: Thu Feb 26 2026 - 23:23:30 EST


On 2/27/26 12:52 AM, Bjorn Andersson wrote:
On Tue, Feb 24, 2026 at 03:45:05PM -0300, Val Packett wrote:
On 2/23/26 5:03 PM, Bjorn Andersson wrote:
On Sun, Feb 01, 2026 at 05:55:03PM -0300, Val Packett wrote:
The changes introduced to handle single power domain platforms have
swapped the info pointer increment from num_pd_vregs to num_pds, which
would shift the info pointer past the end of the array for pronto-v3,
which does not list power domain regulators in vregs.

This showed up as a difference between GCC- and LLVM-compiled kernels
on SDM632 devices, where only with LLVM one would get the
"regulator request with no identifier" error, because the out-of-bounds
memory ended up being zeroed. Fix by skipping the increment when there
are more power domains than regulators.

Is the error only an error print, or did the thing stop working as well?
It's a real error. Likely no one would've bothered debugging it if it
weren't breaking everything :)

It was a blocker for allowing LLVM/clang builds of the msm8953 kernel in
postmarketOS, the whole reason to dig into this was "switching to clang
breaks the modem, WTF?!"

Can you provide me with a Fixes: line please?

Oops, did I lose it at some point? o.0 Sorry!

Fixes: 65991ea8a6d1 ("remoteproc: qcom_wcnss: Handle platforms with only single power domain")


~val