Re: [PATCH] staging: rtl8723bs: Fix logical continuation placement

[Dan Carpenter]

On Thu, Feb 26, 2026 at 07:31:34PM -0600, Ethan Tidmore wrote:
> On Thu Feb 26, 2026 at 3:38 AM CST, Mariyam Shahid wrote:
> > Move logical operators to the end of the previous line
> > to fix checkpatch warnings.
> >
> > Signed-off-by: Mariyam Shahid <mariyam.shahid135@xxxxxxxxx>
> > ---
> 
> ...
> 
> 
> > -	if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT)
> > -	    && pmlmepriv->num_sta_ht_no_gf) {
> > +	if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
> > +	      pmlmepriv->num_sta_ht_no_gf) {
> 
> This should be:
> 
> 	if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
> 		pmlmepriv->num_sta_ht_no_gf) {

Ideally, it would be aligned.

	if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
	    pmlmepriv->num_sta_ht_no_gf) {

[tab][space * 4]pmlmepriv->num_sta_ht_no_gf) {

regards,
dan carpenter