Re: [PATCH v3 3/3] dt-bindings: mmc: synopsys-dw-mshc: No need to enforce setting two clocks
From: Krzysztof Kozlowski
Date: Fri Feb 27 2026 - 02:51:27 EST
On Thu, Feb 26, 2026 at 05:10:51PM +0800, ping.gao wrote:
> The driver `dw_mmc.c` now treats the biu clock as optional, so the
> binding can be relaxed to allow a single clock.
Not sufficient, bring also arguments in terms of hardware. If the
hardware needs biu, then this is wrong.
Missing blank line.
> Signed-off-by: ping.gao <ping.gao@xxxxxxxxxxx>
Are you sure your name includes "." or you just use login as name?
> ---
> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> index a6292777e376..7a02fb6f585b 100644
> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> @@ -24,11 +24,12 @@ properties:
> maxItems: 1
>
> clocks:
> - minItems: 2
> + minItems: 1
> maxItems: 2
> description:
> Handle to "biu" and "ciu" clocks for the
> bus interface unit clock and the card interface unit clock.
> + If only one clock is present it must be "ciu" clock.
Drop, don't repeat the schema.
>
> clock-names:
> items:
De-synced with clock-names, so not really tested.
Best regards,
Krzysztof