Re: [PATCH] mtd: physmap_of_gemini: Fix disabled pinctrl state check

From: Linus Walleij

Date: Fri Feb 27 2026 - 04:00:46 EST


On Fri, Feb 27, 2026 at 2:44 AM Chen Ni <nichen@xxxxxxxxxxx> wrote:

> The condition for checking the disabled pinctrl state incorrectly checks
> gf->enabled_state instead of gf->disabled_state. This causes misleading
> error messages and could lead to incorrect behavior when only one of the
> pinctrl states is defined.
>
> Fix the condition to properly check gf->disabled_state.
>
> Fixes: 9d3b5086f6d4 ("mtd: physmap_of_gemini: Handle pin control")
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>

Ooops! Thanks for finding this Chen!
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij