Re: [PATCH v4 1/3] dt-bindings: dma: Add Amlogic A9 SoC DMA

[Xianwei Zhao]

On 2026/2/27 17:44, Krzysztof Kozlowski wrote:
> On 27/02/2026 10:43, Xianwei Zhao wrote:
> > > > new file mode 100644
> > > > index 000000000000..025ecc42e395
> > > > --- /dev/null
> > > > +++ b/include/dt-bindings/dma/amlogic-dma.h
> > > > @@ -0,0 +1,8 @@
> > > > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> > > > +
> > > > +#ifndef __DT_BINDINGS_DMA_AMLOGIC_DMA_H__
> > > > +#define __DT_BINDINGS_DMA_AMLOGIC_DMA_H__
> > > > +
> > > > +#define AML_DMA_TYPE_TX              0
> > > > +#define AML_DMA_TYPE_RX              1
> > > You sure you need AML prefix? Your clock constants do not have AML
> > > prefixes. What other constants do you expect here?
> > I will delete AML prefix in next version.
> I assume this is an argument to "dma" phandle (cells), so maybe should
> be "DMA_TX/RX"?

Thank you for your suggestion. I'll use it.

> Best regards,
> Krzysztof