Re: [PATCH v2] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_stop()

[Richard Fitzgerald]

On 02/02/2026 2:41 pm, Ziyi Guo wrote:
> cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control()
> which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held.
>
> cs_dsp_signal_event_controls() is invoked from cs_dsp_stop().
>
> Put mutex_lock() at the top of cs_dsp_stop() to fix the
> missing lock protection, also align with cs_dsp_run().
>
> Signed-off-by: Ziyi Guo <n7l8m4@xxxxxxxxxxxxxxxxxx>
> ---
> v2:
>   - Put mutex_lock() at the top of cs_dsp_stop() to fix and align with cs_dsp_run()

You need to send this patch to Mark Brown <broonie@xxxxxxxxxx> and also
add linux-sound@xxxxxxxxxxxxxxx to your cc list